Refactor status code handling: better logic split and an ability to override the code #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… send_headers callback. Add ability to override the error code via a vip_maintenance_mode_origin_status_code filter
GaryJones
force-pushed
the
update/custom-error-code
branch
from
197b7af to
5ac2c66
Compare
|
The CI checks are a bit of a false confidence here, as there is only one PHP test, and the PHPCS isn't run, but it's marked as passing now it has been rebased. |
|
@rinatkhaziev Is this still desired? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
send_headerscallback, which seems to be more appropriate rather than stuffing intemplate_redirectvip_maintenance_mode_origin_status_code. This is needed to disambiguate the user-triggered 503 coming from application with server-side generated 503.566in vipgo-helper.php